Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: net/cert/cert_verify_proc_openssl.cc

Issue 361193003: Eliminate ScopedOpenSSL in favour of scoped_ptr<> specializations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android fixes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_verify_proc_openssl.h" 5 #include "net/cert/cert_verify_proc_openssl.h"
6 6
7 #include <openssl/x509v3.h> 7 #include <openssl/x509v3.h>
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/sha1.h" 13 #include "base/sha1.h"
14 #include "crypto/openssl_util.h" 14 #include "crypto/openssl_util.h"
15 #include "crypto/scoped_openssl_types.h"
15 #include "crypto/sha2.h" 16 #include "crypto/sha2.h"
16 #include "net/base/net_errors.h" 17 #include "net/base/net_errors.h"
17 #include "net/cert/asn1_util.h" 18 #include "net/cert/asn1_util.h"
18 #include "net/cert/cert_status_flags.h" 19 #include "net/cert/cert_status_flags.h"
19 #include "net/cert/cert_verifier.h" 20 #include "net/cert/cert_verifier.h"
20 #include "net/cert/cert_verify_result.h" 21 #include "net/cert/cert_verify_result.h"
21 #include "net/cert/test_root_certs.h" 22 #include "net/cert/test_root_certs.h"
22 #include "net/cert/x509_certificate.h" 23 #include "net/cert/x509_certificate.h"
23 24
24 namespace net { 25 namespace net {
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 CRLSet* crl_set, 191 CRLSet* crl_set,
191 const CertificateList& additional_trust_anchors, 192 const CertificateList& additional_trust_anchors,
192 CertVerifyResult* verify_result) { 193 CertVerifyResult* verify_result) {
193 crypto::EnsureOpenSSLInit(); 194 crypto::EnsureOpenSSLInit();
194 195
195 if (!cert->VerifyNameMatch(hostname, 196 if (!cert->VerifyNameMatch(hostname,
196 &verify_result->common_name_fallback_used)) { 197 &verify_result->common_name_fallback_used)) {
197 verify_result->cert_status |= CERT_STATUS_COMMON_NAME_INVALID; 198 verify_result->cert_status |= CERT_STATUS_COMMON_NAME_INVALID;
198 } 199 }
199 200
200 crypto::ScopedOpenSSL<X509_STORE_CTX, X509_STORE_CTX_free> ctx( 201 scoped_ptr<X509_STORE_CTX,
201 X509_STORE_CTX_new()); 202 crypto::OpenSSLDestroyer<X509_STORE_CTX, X509_STORE_CTX_free> >
203 ctx(X509_STORE_CTX_new());
202 204
203 crypto::ScopedOpenSSL<STACK_OF(X509), sk_X509_free_fn> intermediates( 205 scoped_ptr<STACK_OF(X509),
204 sk_X509_new_null()); 206 crypto::OpenSSLDestroyer<STACK_OF(X509), sk_X509_free_fn> >
207 intermediates(sk_X509_new_null());
205 if (!intermediates.get()) 208 if (!intermediates.get())
206 return ERR_OUT_OF_MEMORY; 209 return ERR_OUT_OF_MEMORY;
207 210
208 const X509Certificate::OSCertHandles& os_intermediates = 211 const X509Certificate::OSCertHandles& os_intermediates =
209 cert->GetIntermediateCertificates(); 212 cert->GetIntermediateCertificates();
210 for (X509Certificate::OSCertHandles::const_iterator it = 213 for (X509Certificate::OSCertHandles::const_iterator it =
211 os_intermediates.begin(); it != os_intermediates.end(); ++it) { 214 os_intermediates.begin(); it != os_intermediates.end(); ++it) {
212 if (!sk_X509_push(intermediates.get(), *it)) 215 if (!sk_X509_push(intermediates.get(), *it))
213 return ERR_OUT_OF_MEMORY; 216 return ERR_OUT_OF_MEMORY;
214 } 217 }
(...skipping 16 matching lines...) Expand all
231 234
232 GetCertChainInfo(ctx.get(), verify_result); 235 GetCertChainInfo(ctx.get(), verify_result);
233 AppendPublicKeyHashes(ctx.get(), &verify_result->public_key_hashes); 236 AppendPublicKeyHashes(ctx.get(), &verify_result->public_key_hashes);
234 if (IsCertStatusError(verify_result->cert_status)) 237 if (IsCertStatusError(verify_result->cert_status))
235 return MapCertStatusToNetError(verify_result->cert_status); 238 return MapCertStatusToNetError(verify_result->cert_status);
236 239
237 return OK; 240 return OK;
238 } 241 }
239 242
240 } // namespace net 243 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698