Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
361133002:
[Hotword] Adding hotword watchlist. (Closed)
|
Created:
6 years, 5 months ago by rpetterson Modified:
6 years, 5 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
Description[Hotword] Adding hotword watchlist.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281797
Patch Set 1 #
Total comments: 2
Patch Set 2 : add slash #Messages
Total messages: 17 (0 generated)
+isherman
LGTM % comment. https://codereview.chromium.org/361133002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/361133002/diff/1/WATCHLISTS#newcode351 WATCHLISTS:351: 'filepath': 'chrome/browser/extensions/api/hotword_private/' I think you want a trailing '\' on this line.
https://codereview.chromium.org/361133002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/361133002/diff/1/WATCHLISTS#newcode351 WATCHLISTS:351: 'filepath': 'chrome/browser/extensions/api/hotword_private/' On 2014/07/07 21:38:32, Ilya Sherman wrote: > I think you want a trailing '\' on this line. Done.
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/361133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/361133002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
The CQ bit was checked by rlp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/361133002/20001
Message was sent while issue was closed.
Change committed as 281797 |
