Mojo surfaces service and example app

Mojo surfaces service and example app

This provides an implementation of the mojo surfaces service and a
sample with two mojo applications composing each other via surfaces. The
viewport / display hookup is a bit of a hack in this patch as is the
complete lack of scheduling logic, but it's enough to get started.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282856

[jamesr, 2014-07-02 18:02:28]

This provides an implementation of the surfaces service and a pretty simple
sample app that uses it to embed 2 instances of a child app.

The binding to a viewport here is a bit of a hack - it's assuming there is only
one viewport in the mojo world and doesn't attempt to do any intelligent
scheduling.  This part will need a lot more work but I think the rest is fine
and we can continue to iterate.

[Ben Goodger (Google), 2014-07-07 21:07:34]

https://codereview.chromium.org/361123002/diff/20001/mojo/examples/surfaces_a...
File mojo/examples/surfaces_app/child.mojom (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/examples/surfaces_a...
mojo/examples/surfaces_app/child.mojom:11: (mojo.surfaces.SurfaceId id);
should we be doing a 4-space indent here? we have no mojom style guide, so I'm
assuming it's like C++ in that wraps get indented 2 more spaces.

https://codereview.chromium.org/361123002/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:287: #'mojo_system_impl',
???

https://codereview.chromium.org/361123002/diff/20001/mojo/services/public/int...
File mojo/services/public/interfaces/surfaces/surfaces.mojom (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/services/public/int...
mojo/services/public/interfaces/surfaces/surfaces.mojom:64:
CreateGLES2BoundSurface(mojo.CommandBuffer gles2_client, SurfaceId id, mojo.Size
size);
nit: 80-col

https://codereview.chromium.org/361123002/diff/20001/mojo/services/surfaces/s...
File mojo/services/surfaces/surfaces_impl.cc (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/services/surfaces/s...
mojo/services/surfaces/surfaces_impl.cc:76:
context_->SetDisplay(display_.get());
this means there can be only app connected to the surfaces service. is that your
intention?

[jamesr, 2014-07-07 21:11:41]

https://codereview.chromium.org/361123002/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:287: #'mojo_system_impl',
On 2014/07/07 21:07:33, Ben Goodger (Google) wrote:
> ???
whoops, must be a merge artifact or something. I don't think the app should link
against system_impl - will delete

https://codereview.chromium.org/361123002/diff/20001/mojo/services/surfaces/s...
File mojo/services/surfaces/surfaces_impl.cc (right):

https://codereview.chromium.org/361123002/diff/20001/mojo/services/surfaces/s...
mojo/services/surfaces/surfaces_impl.cc:76:
context_->SetDisplay(display_.get());
On 2014/07/07 21:07:34, Ben Goodger (Google) wrote:
> this means there can be only app connected to the surfaces service. is that
your
> intention?

No - as the patch comments say the display hookup is a hack for now since the
shell only really supports one native viewport (afaik).  I intend to add a
proper API for manipulating displays and binding them to viewports once there's
a way to express it at the lower level.  Today, connecting to the native
viewport service essentially binds you to the "only" native viewport in the
ecosystem, which we'll need to refine.

[Ben Goodger (Google), 2014-07-08 15:49:57]

lgtm

[jamesr, 2014-07-09 22:50:39]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-09 22:53:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/361123002/40001

[commit-bot: I haz the power, 2014-07-10 02:43:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-10 02:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 02:52:00]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[jamesr, 2014-07-10 21:44:11]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-10 21:44:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/361123002/60001

[commit-bot: I haz the power, 2014-07-10 22:05:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/27212)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/31645)

[commit-bot: I haz the power, 2014-07-10 22:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 22:07:40]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/27220)

[jamesr, 2014-07-10 22:15:24]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-10 22:17:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/361123002/80001

[commit-bot: I haz the power, 2014-07-11 02:39:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-11 03:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 03:09:05]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[jamesr, 2014-07-12 23:43:01]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-12 23:43:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/361123002/100001

[commit-bot: I haz the power, 2014-07-13 00:55:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-13 01:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-13 01:04:36]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jamesr, 2014-07-13 01:30:18]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-13 01:31:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/361123002/120001

[commit-bot: I haz the power, 2014-07-13 03:14:29]

Change committed as 282856