Issue 361083004: Tab and TabCloseButton should implement MaskedTargeterDelegate

Issue 361083004: Tab and TabCloseButton should implement MaskedTargeterDelegate (Closed)

Created:
6 years, 5 months ago by tdanderson

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Tab and TabCloseButton should implement MaskedTargeterDelegate Define the hit test masks for Tab and TabCloseButton by implementing MaskedTargeterDelegate instead of overriding View::HasHitTestMask() and View::GetHitTestMaskDeprecated(). BUG=388838 TEST=Existing coverage in TabStripTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282363

Patch Set 1 #

Patch Set 2 : rebase against ToT #

Patch Set 3 : re-upload #

Patch Set 4 : tab strip test failures fixed #

Patch Set 5 : . #

Patch Set 6 : re-upload #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -69 lines)			Patch
M	chrome/browser/ui/views/tabs/tab.h	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View		8 chunks	+99 lines, -60 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip_unittest.cc	View	1 2 3	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tdanderson

Sadrul, could you please take a first look through this?

6 years, 5 months ago (2014-07-04 18:58:20 UTC) #2

tdanderson

Scott, can you please take a look? (Removing Sadrul as first-pass reviewer since he's OOO ...

6 years, 5 months ago (2014-07-09 20:06:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/361083004/100001

6 years, 5 months ago (2014-07-10 15:57:31 UTC) #6

Message was sent while issue was closed.

Change committed as 282363

Expand Messages | Collapse Messages