net/quic/quic_in_memory_cache.h - Issue 361083002: Small cleanups to ported QuicServer and dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_in_memory_cache.h

Issue 361083002: Small cleanups to ported QuicServer and dependencies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring back quic_tools (formerly quic_ported_server) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_in_memory_cache.h

diff --git a/net/quic/quic_in_memory_cache.h b/net/quic/quic_in_memory_cache.h

index e37ce2bdf9e9f6034df49418081d35b0f369b3bc..b064f5d0a2056ce585e8b4e0692a7b506cb1e0ad 100644

--- a/net/quic/quic_in_memory_cache.h

+++ b/net/quic/quic_in_memory_cache.h

@@ -44,7 +44,7 @@ class QuicInMemoryCache {

~Response();

SpecialResponseType response_type() const { return response_type_; }

- const HttpResponseHeaders& headers() const { return *headers_; }

+ const HttpResponseHeaders* headers() const { return headers_.get(); }

Ryan Hamilton 2014/07/02 19:31:31 Why did this change?

dmz 2014/07/02 20:58:39 Because headers_ might be null. However, I'm undoi

const base::StringPiece body() const { return base::StringPiece(body_); }

private:

« no previous file with comments | « net/net.gyp ('k') | net/quic/quic_spdy_server_stream.cc » ('j') | net/quic/quic_spdy_server_stream.cc » ('J')