Small cleanups to ported QuicServer and dependencies

net/quic/quic_in_memory_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_in_memory_cache.h"
 
 #include "base/files/file_enumerator.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "net/http/http_util.h"
 #include "url/gurl.h"
 
 using base::FilePath;
 using base::StringPiece;
 using std::string;
 
 // Specifies the directory used during QuicInMemoryCache
 // construction to seed the cache. Cache directory can be
 // generated using `wget -p --save-headers <url>
 
 namespace net {
 
-FilePath::StringType g_quic_in_memory_cache_dir = FILE_PATH_LITERAL("");
+FilePath::StringType* g_quic_in_memory_cache_dir = NULL;
 
 QuicInMemoryCache::Response::Response() : response_type_(REGULAR_RESPONSE) {
 }
 
 QuicInMemoryCache::Response::~Response() {
 }
 
 // static
 QuicInMemoryCache* QuicInMemoryCache::GetInstance() {
   return Singleton<QuicInMemoryCache>::get();
@@ skipping 56 matching lines @@
   Initialize();
 }
 
 void QuicInMemoryCache::ResetForTests() {
   STLDeleteValues(&responses_);
   Initialize();
 }
 
 void QuicInMemoryCache::Initialize() {
   // If there's no defined cache dir, we have no initialization to do.
-  if (g_quic_in_memory_cache_dir.size() == 0) {
+  if (g_quic_in_memory_cache_dir == NULL) {
     VLOG(1) << "No cache directory found. Skipping initialization.";
     return;
   }
   VLOG(1) << "Attempting to initialize QuicInMemoryCache from directory: "
-          << g_quic_in_memory_cache_dir;
+          << *g_quic_in_memory_cache_dir;
 
-  FilePath directory(g_quic_in_memory_cache_dir);
+  FilePath directory(*g_quic_in_memory_cache_dir);
   base::FileEnumerator file_list(directory,
                                  true,
                                  base::FileEnumerator::FILES);
 
   FilePath file = file_list.Next();
   for (; !file.empty(); file = file_list.Next()) {
     // Need to skip files in .svn directories
     if (file.value().find(FILE_PATH_LITERAL("/.svn/")) != string::npos) {
       continue;
     }
@@ skipping 55 matching lines @@
 QuicInMemoryCache::~QuicInMemoryCache() {
   STLDeleteValues(&responses_);
 }
 
 string QuicInMemoryCache::GetKey(const GURL& url) const {
   // Take everything but the scheme portion of the URL.
   return url.host() + url.PathForRequest();
 }
 
 }  // namespace net