Add switch to disable recording whole document

Add switch to disable recording whole document

Add an android webview switch to disable the workaround to record the
whole document on in each commit. The setting is plumbed through
SynchronousCompositorFactory.

BUG=390702
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280970

[boliu, 2014-07-01 21:58:19]

James, could you review content/renderer and cc

[jamesr, 2014-07-01 22:16:12]

'document' is a concept that doesn't really exist in cc, it's a higher-level
thing. Can you think of a way to express this functionality in a way that makes
sense in the compositor?  Maybe 'RecordFullLayer' or something like that?

[jamesr, 2014-07-01 22:17:10]

https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:519:
SynchronousCompositorFactory::GetInstance();
if this is just accessing statics, why is it on RenderWidget? why not put this
code in RenderWidgetCompositor directly? it doesn't depend on any state that the
RenderWidget owns.

[boliu, 2014-07-01 22:22:05]

https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:519:
SynchronousCompositorFactory::GetInstance();
On 2014/07/01 22:17:10, jamesr wrote:
> if this is just accessing statics, why is it on RenderWidget? why not put this
> code in RenderWidgetCompositor directly? it doesn't depend on any state that
the
> RenderWidget owns.

Following the pattern of UsingSynchronousRendererCompositor above. I think it
can be moved to RenderWidgetCompositor too?

[jamesr, 2014-07-01 22:22:52]

On 2014/07/01 22:22:05, boliu wrote:
>
https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
> File content/renderer/render_widget.cc (right):
> 
>
https://codereview.chromium.org/361073002/diff/1/content/renderer/render_widg...
> content/renderer/render_widget.cc:519:
> SynchronousCompositorFactory::GetInstance();
> On 2014/07/01 22:17:10, jamesr wrote:
> > if this is just accessing statics, why is it on RenderWidget? why not put
this
> > code in RenderWidgetCompositor directly? it doesn't depend on any state that
> the
> > RenderWidget owns.
> 
> Following the pattern of UsingSynchronousRendererCompositor above. I think it
> can be moved to RenderWidgetCompositor too?

I think so. If we end up needing state from RenderWidget in the future we can
move it back but having this entirely in RenderWidgetCompositor seems like a
good simplification to me.

[boliu, 2014-07-01 22:59:21]

PTAL

Renamed to RecordFullLayer in content, which are all "compositor" changes. Kept
the record whole document name under android_webview where I think it makes more
sense.

Had to shuffle around code into defined(OS_ANDROID) block in
render_widget_compositor.cc to get rid of
RenderWidget::UsingSynchronousRendererCompositor.

[jamesr, 2014-07-01 23:09:19]

lgtm

[boliu, 2014-07-01 23:10:27]

+yaron for the android bits

[Yaron, 2014-07-02 00:37:12]

lgtm

https://codereview.chromium.org/361073002/diff/20001/android_webview/common/a...
File android_webview/common/aw_switches.h (right):

https://codereview.chromium.org/361073002/diff/20001/android_webview/common/a...
android_webview/common/aw_switches.h:10: extern const char
kDisableRecordDocumentWorkaround[];
Add comment

[boliu, 2014-07-02 00:41:45]

Thanks all.

https://codereview.chromium.org/361073002/diff/20001/android_webview/common/a...
File android_webview/common/aw_switches.h (right):

https://codereview.chromium.org/361073002/diff/20001/android_webview/common/a...
android_webview/common/aw_switches.h:10: extern const char
kDisableRecordDocumentWorkaround[];
On 2014/07/02 00:37:12, Yaron wrote:
> Add comment

Done.

[boliu, 2014-07-02 00:41:52]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-07-02 00:42:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/361073002/40001

[commit-bot: I haz the power, 2014-07-02 02:42:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 02:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 02:48:51]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[boliu, 2014-07-02 03:32:59]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-07-02 03:34:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/361073002/40001

[commit-bot: I haz the power, 2014-07-02 07:31:39]

Change committed as 280970