Fix threading issues in BlacklistManager, using new ChromeThread.

chrome/browser/extensions/extensions_service.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extensions_service.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/string_util.h"
@@ skipping 724 matching lines @@
                   Details<const std::string>(&error));
 
   // TODO(port): note that this isn't guaranteed to work properly on Linux.
   std::string path_str = WideToASCII(extension_path.ToWStringHack());
   std::string message = StringPrintf("Could not load extension from '%s'. %s",
                                      path_str.c_str(), error.c_str());
   ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy);
 }
 
 std::vector<FilePath> ExtensionsService::GetPersistentBlacklistPaths() {
+  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+
   std::vector<FilePath> result;
   for (ExtensionList::const_iterator extension_iter = extensions()->begin();
        extension_iter != extensions()->end(); ++extension_iter) {
     if ((*extension_iter)->location() == Extension::LOAD)
       continue;
 
     std::vector<Extension::PrivacyBlacklistInfo> blacklists(
         (*extension_iter)->privacy_blacklists());
     std::vector<Extension::PrivacyBlacklistInfo>::const_iterator blacklist_iter;
     for (blacklist_iter = blacklists.begin();
          blacklist_iter != blacklists.end(); ++blacklist_iter) {
       result.push_back(blacklist_iter->path);
     }
   }
   return result;
 }
 
 std::vector<FilePath> ExtensionsService::GetTransientBlacklistPaths() {
+  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+
   std::vector<FilePath> result;
   for (ExtensionList::const_iterator extension_iter = extensions()->begin();
        extension_iter != extensions()->end(); ++extension_iter) {
     if ((*extension_iter)->location() != Extension::LOAD)
       continue;
 
     std::vector<Extension::PrivacyBlacklistInfo> blacklists(
         (*extension_iter)->privacy_blacklists());
     std::vector<Extension::PrivacyBlacklistInfo>::const_iterator blacklist_iter;
     for (blacklist_iter = blacklists.begin();
@@ skipping 174 matching lines @@
 
 void ExtensionsServiceBackend::OnExternalExtensionFound(
     const std::string& id, const Version* version, const FilePath& path,
     Extension::Location location) {
   ChromeThread::PostTask(
       ChromeThread::UI, FROM_HERE,
       NewRunnableMethod(
           frontend_, &ExtensionsService::OnExternalExtensionFound, id,
           version->GetString(), path, location));
 }