Issue 361004: Remove TODO comments in code generation for typeof subexpressions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361004: Remove TODO comments in code generation for typeof subexpressions.... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove TODO comments in code generation for typeof subexpressions. The 'phantom' property used for evaluation of typeof does not have a source-code position, just like other phantom properties in V8 (eg, global variables, parameters rewritten to arguments accesses, etc.).

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -6 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 1 month ago (2009-11-04 18:00:20 UTC) #3

I committed this as part of r3218 (http://codereview.chromium.org/360011/show)
so as not to submit a comments-only change.

Expand Messages | Collapse Messages