Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 360843002: MSE: Move FrameProcessorBase code into FrameProcessor (Closed)

Created:
6 years, 5 months ago by wolenetz
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MSE: Move FrameProcessorBase code into FrameProcessor Now that LegacyFrameProcessor is no more, the FrameProcessorBase class is no longer needed. This change moves the base code into the FrameProcessor class. R=acolwell@chromium.org BUG=249422 TEST=No media unittest or MSE layout test regression locally on Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280884

Patch Set 1 #

Patch Set 2 : Fix lint error #

Total comments: 2

Patch Set 3 : Moves MseTrackBuffer into .cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -469 lines) Patch
M media/filters/chunk_demuxer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/filters/frame_processor.h View 1 2 2 chunks +121 lines, -13 lines 0 comments Download
M media/filters/frame_processor.cc View 1 2 2 chunks +279 lines, -2 lines 0 comments Download
D media/filters/frame_processor_base.h View 1 chunk +0 lines, -234 lines 0 comments Download
D media/filters/frame_processor_base.cc View 1 chunk +0 lines, -214 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wolenetz
PTAL @ PS2. This change does not depend on https://codereview.chromium.org/309933002/.
6 years, 5 months ago (2014-06-30 23:20:42 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % nit https://codereview.chromium.org/360843002/diff/20001/media/filters/frame_processor.h File media/filters/frame_processor.h (right): https://codereview.chromium.org/360843002/diff/20001/media/filters/frame_processor.h#newcode24 media/filters/frame_processor.h:24: class MseTrackBuffer { nit: It doesn't ...
6 years, 5 months ago (2014-07-01 17:40:22 UTC) #2
wolenetz
Thank you for reviewing. https://codereview.chromium.org/360843002/diff/20001/media/filters/frame_processor.h File media/filters/frame_processor.h (right): https://codereview.chromium.org/360843002/diff/20001/media/filters/frame_processor.h#newcode24 media/filters/frame_processor.h:24: class MseTrackBuffer { On 2014/07/01 ...
6 years, 5 months ago (2014-07-01 18:16:40 UTC) #3
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 5 months ago (2014-07-01 18:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/360843002/40001
6 years, 5 months ago (2014-07-01 18:17:18 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 21:13:26 UTC) #6
Message was sent while issue was closed.
Change committed as 280884

Powered by Google App Engine
This is Rietveld 408576698