Source/core/rendering/svg/RenderSVGGradientStop.h - Issue 360833002: Divorce PaintInvalidationState from LayoutState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGGradientStop.h

Issue 360833002: Divorce PaintInvalidationState from LayoutState (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address Julien's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/RenderSVGGradientStop.h

diff --git a/Source/core/rendering/svg/RenderSVGGradientStop.h b/Source/core/rendering/svg/RenderSVGGradientStop.h

index 4d6fee111217ce5237b748d4387d2abff9eeebfd..97d3e3ee040d1545326f95abf796ed95ce1307a7 100644

--- a/Source/core/rendering/svg/RenderSVGGradientStop.h

+++ b/Source/core/rendering/svg/RenderSVGGradientStop.h

@@ -43,7 +43,7 @@ public:

// This overrides are needed to prevent ASSERTs on <svg><stop /></svg>

// RenderObject's default implementations ASSERT_NOT_REACHED()

// https://bugs.webkit.org/show_bug.cgi?id=20400

- virtual LayoutRect clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject*) const OVERRIDE { return LayoutRect(); }

+ virtual LayoutRect clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject*, const PaintInvalidationState* = 0) const OVERRIDE { return LayoutRect(); }

virtual FloatRect objectBoundingBox() const OVERRIDE { return FloatRect(); }

virtual FloatRect strokeBoundingBox() const OVERRIDE { return FloatRect(); }

virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE { return FloatRect(); }

« no previous file with comments | « Source/core/rendering/svg/RenderSVGForeignObject.cpp ('k') | Source/core/rendering/svg/RenderSVGHiddenContainer.h » ('j') | no next file with comments »