Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 360833002: Divorce PaintInvalidationState from LayoutState (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ToT-ed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1008 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 // We should only invalidate paints for the outer most layout. This works as 1019 // We should only invalidate paints for the outer most layout. This works as
1020 // we continue to track paint invalidation rects until this function is call ed. 1020 // we continue to track paint invalidation rects until this function is call ed.
1021 ASSERT(!m_nestedLayoutCount); 1021 ASSERT(!m_nestedLayoutCount);
1022 1022
1023 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", root->debugName() .ascii()); 1023 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", root->debugName() .ascii());
1024 1024
1025 // FIXME: really, we're in the paint invalidation phase here, and the compos iting queries are legal. 1025 // FIXME: really, we're in the paint invalidation phase here, and the compos iting queries are legal.
1026 // Until those states are fully fledged, I'll just disable the ASSERTS. 1026 // Until those states are fully fledged, I'll just disable the ASSERTS.
1027 DisableCompositingQueryAsserts compositingQueryAssertsDisabler; 1027 DisableCompositingQueryAsserts compositingQueryAssertsDisabler;
1028 1028
1029 LayoutState rootLayoutState(*root); 1029 InvalidationTreeWalkState invalidationTreeWalkState(*root);
1030 1030
1031 root->invalidateTreeAfterLayout(*root->containerForPaintInvalidation()); 1031 root->invalidateTreeAfterLayout(invalidationTreeWalkState);
1032 1032
1033 // Invalidate the paint of the frameviews scrollbars if needed 1033 // Invalidate the paint of the frameviews scrollbars if needed
1034 if (hasVerticalBarDamage()) 1034 if (hasVerticalBarDamage())
1035 invalidateRect(verticalBarDamage()); 1035 invalidateRect(verticalBarDamage());
1036 if (hasHorizontalBarDamage()) 1036 if (hasHorizontalBarDamage())
1037 invalidateRect(horizontalBarDamage()); 1037 invalidateRect(horizontalBarDamage());
1038 resetScrollbarDamage(); 1038 resetScrollbarDamage();
1039 } 1039 }
1040 1040
1041 DocumentLifecycle& FrameView::lifecycle() const 1041 DocumentLifecycle& FrameView::lifecycle() const
(...skipping 2223 matching lines...) Expand 10 before | Expand all | Expand 10 after
3265 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3265 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3266 { 3266 {
3267 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3267 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3268 if (AXObjectCache* cache = axObjectCache()) { 3268 if (AXObjectCache* cache = axObjectCache()) {
3269 cache->remove(scrollbar); 3269 cache->remove(scrollbar);
3270 cache->handleScrollbarUpdate(this); 3270 cache->handleScrollbarUpdate(this);
3271 } 3271 }
3272 } 3272 }
3273 3273
3274 } // namespace WebCore 3274 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698