Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 360833002: Divorce PaintInvalidationState from LayoutState (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address Julien's comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 RenderSVGModelObject::RenderSVGModelObject(SVGElement* node) 43 RenderSVGModelObject::RenderSVGModelObject(SVGElement* node)
44 : RenderObject(node) 44 : RenderObject(node)
45 { 45 {
46 } 46 }
47 47
48 bool RenderSVGModelObject::isChildAllowed(RenderObject* child, RenderStyle*) con st 48 bool RenderSVGModelObject::isChildAllowed(RenderObject* child, RenderStyle*) con st
49 { 49 {
50 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText()) ; 50 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText()) ;
51 } 51 }
52 52
53 LayoutRect RenderSVGModelObject::clippedOverflowRectForPaintInvalidation(const R enderLayerModelObject* paintInvalidationContainer) const 53 LayoutRect RenderSVGModelObject::clippedOverflowRectForPaintInvalidation(const R enderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const
54 { 54 {
55 return SVGRenderSupport::clippedOverflowRectForRepaint(this, paintInvalidati onContainer); 55 return SVGRenderSupport::clippedOverflowRectForRepaint(this, paintInvalidati onContainer, paintInvalidationState);
56 } 56 }
57 57
58 void RenderSVGModelObject::computeFloatRectForPaintInvalidation(const RenderLaye rModelObject* paintInvalidationContainer, FloatRect& paintInvalidationRect, bool fixed) const 58 void RenderSVGModelObject::computeFloatRectForPaintInvalidation(const RenderLaye rModelObject* paintInvalidationContainer, FloatRect& paintInvalidationRect, bool fixed, const PaintInvalidationState* paintInvalidationState) const
59 { 59 {
60 SVGRenderSupport::computeFloatRectForRepaint(this, paintInvalidationContaine r, paintInvalidationRect, fixed); 60 SVGRenderSupport::computeFloatRectForRepaint(this, paintInvalidationContaine r, paintInvalidationRect, fixed, paintInvalidationState);
61 } 61 }
62 62
63 void RenderSVGModelObject::mapLocalToContainer(const RenderLayerModelObject* rep aintContainer, TransformState& transformState, MapCoordinatesFlags, bool* wasFix ed) const 63 void RenderSVGModelObject::mapLocalToContainer(const RenderLayerModelObject* rep aintContainer, TransformState& transformState, MapCoordinatesFlags, bool* wasFix ed, const PaintInvalidationState* paintInvalidationState) const
64 { 64 {
65 SVGRenderSupport::mapLocalToContainer(this, repaintContainer, transformState , wasFixed); 65 SVGRenderSupport::mapLocalToContainer(this, repaintContainer, transformState , wasFixed, paintInvalidationState);
66 } 66 }
67 67
68 const RenderObject* RenderSVGModelObject::pushMappingToContainer(const RenderLay erModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const 68 const RenderObject* RenderSVGModelObject::pushMappingToContainer(const RenderLay erModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const
69 { 69 {
70 return SVGRenderSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap); 70 return SVGRenderSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap);
71 } 71 }
72 72
73 void RenderSVGModelObject::absoluteRects(Vector<IntRect>& rects, const LayoutPoi nt& accumulatedOffset) const 73 void RenderSVGModelObject::absoluteRects(Vector<IntRect>& rects, const LayoutPoi nt& accumulatedOffset) const
74 { 74 {
75 IntRect rect = enclosingIntRect(strokeBoundingBox()); 75 IntRect rect = enclosingIntRect(strokeBoundingBox());
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 return false; 117 return false;
118 } 118 }
119 119
120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads 120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads
121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds. 121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds.
122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads) 122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)
123 { 123 {
124 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates()))); 124 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates())));
125 } 125 }
126 126
127 void RenderSVGModelObject::invalidateTreeAfterLayout(const RenderLayerModelObjec t& paintInvalidationContainer) 127 void RenderSVGModelObject::invalidateTreeAfterLayout(const PaintInvalidationStat e& paintInvalidationState)
128 { 128 {
129 // Note: This is a reduced version of RenderBox::invalidateTreeAfterLayout() . 129 // Note: This is a reduced version of RenderBox::invalidateTreeAfterLayout() .
130 // FIXME: Should share code with RenderBox::invalidateTreeAfterLayout(). 130 // FIXME: Should share code with RenderBox::invalidateTreeAfterLayout().
131 ASSERT(!needsLayout()); 131 ASSERT(!needsLayout());
132 132
133 if (!shouldCheckForPaintInvalidationAfterLayout()) 133 if (!shouldCheckForPaintInvalidationAfterLayout())
134 return; 134 return;
135 135
136 ForceHorriblySlowRectMapping slowRectMapping(*this); 136 ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState);
137 137
138 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect(); 138 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect();
139 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer(); 139 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer();
140 ASSERT(&paintInvalidationContainer == containerForPaintInvalidation()); 140 ASSERT(paintInvalidationState.paintInvalidationContainer() == containerForPa intInvalidation());
141 setPreviousPaintInvalidationRect(boundsRectForPaintInvalidation(&paintInvali dationContainer)); 141 setPreviousPaintInvalidationRect(boundsRectForPaintInvalidation(&paintInvali dationState.paintInvalidationContainer(), &paintInvalidationState));
142 setPreviousPositionFromPaintInvalidationContainer(RenderLayer::positionFromP aintInvalidationContainer(this, &paintInvalidationContainer)); 142 setPreviousPositionFromPaintInvalidationContainer(RenderLayer::positionFromP aintInvalidationContainer(this, &paintInvalidationState.paintInvalidationContain er(), &paintInvalidationState));
143 143
144 // If an ancestor container had its transform changed, then we just 144 // If an ancestor container had its transform changed, then we just
145 // need to update the RenderSVGModelObject's repaint rect above. The invalid ation 145 // need to update the RenderSVGModelObject's repaint rect above. The invalid ation
146 // will be handled by the container where the transform changed. This essent ially 146 // will be handled by the container where the transform changed. This essent ially
147 // means that we prune the entire branch for performance. 147 // means that we prune the entire branch for performance.
148 if (!SVGRenderSupport::parentTransformDidChange(this)) 148 if (!SVGRenderSupport::parentTransformDidChange(this))
149 return; 149 return;
150 150
151 // If we are set to do a full paint invalidation that means the RenderView w ill be 151 // If we are set to do a full paint invalidation that means the RenderView w ill be
152 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child 152 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child
153 // renderers as they'll be covered by the RenderView. 153 // renderers as they'll be covered by the RenderView.
154 if (view()->doingFullRepaint()) { 154 if (view()->doingFullRepaint()) {
155 RenderObject::invalidateTreeAfterLayout(paintInvalidationContainer); 155 RenderObject::invalidateTreeAfterLayout(paintInvalidationState);
156 return; 156 return;
157 } 157 }
158 158
159 invalidatePaintIfNeeded(containerForPaintInvalidation(), oldPaintInvalidatio nRect, oldPositionFromPaintInvalidationContainer); 159 invalidatePaintIfNeeded(containerForPaintInvalidation(), oldPaintInvalidatio nRect, oldPositionFromPaintInvalidationContainer);
160 160
161 RenderObject::invalidateTreeAfterLayout(paintInvalidationContainer); 161 RenderObject::invalidateTreeAfterLayout(paintInvalidationState);
162 } 162 }
163 163
164 } // namespace WebCore 164 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | Source/core/rendering/svg/RenderSVGRoot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698