Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 360793002: Add multithreaded mode to quilt mode in DM. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add multithreaded mode to quilt mode in DM. Default off for now. Something to work toward. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ec2ae5878d0c4fe3492b6866eaa3b946e526f1a3

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 4

Patch Set 3 : translate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M dm/DMQuiltTask.cpp View 1 2 2 chunks +50 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein_C
Crashes like mad if we flip on threading. Should be we can use this to ...
6 years, 5 months ago (2014-06-30 22:28:17 UTC) #1
robertphillips
lgtm + a question & a nit https://codereview.chromium.org/360793002/diff/20001/dm/DMQuiltTask.cpp File dm/DMQuiltTask.cpp (right): https://codereview.chromium.org/360793002/diff/20001/dm/DMQuiltTask.cpp#newcode44 dm/DMQuiltTask.cpp:44: yOffset = ...
6 years, 5 months ago (2014-07-01 13:59:56 UTC) #2
mtklein_C
https://codereview.chromium.org/360793002/diff/20001/dm/DMQuiltTask.cpp File dm/DMQuiltTask.cpp (right): https://codereview.chromium.org/360793002/diff/20001/dm/DMQuiltTask.cpp#newcode44 dm/DMQuiltTask.cpp:44: yOffset = SkIntToScalar(fY * tile.height()); On 2014/07/01 13:59:56, robertphillips ...
6 years, 5 months ago (2014-07-01 14:07:18 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-01 14:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/360793002/40001
6 years, 5 months ago (2014-07-01 14:16:06 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 14:46:54 UTC) #6
Message was sent while issue was closed.
Change committed as ec2ae5878d0c4fe3492b6866eaa3b946e526f1a3

Powered by Google App Engine
This is Rietveld 408576698