Issue 360773003: [Geolocation] Enable content settings write using permissions bubbles.

Issue 360773003: [Geolocation] Enable content settings write using permissions bubbles. (Closed)

Created:
6 years, 5 months ago by Greg Billock

Modified:
6 years, 5 months ago

Reviewers:
Bernhard Bauer, markusheintz_, Michael van Ouwerkerk

CC:
chromium-reviews, markusheintz_, Michael van Ouwerkerk

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Geolocation] Enable content settings write using permissions bubbles. BUG=352380, 382556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282360

Patch Set 2 : Param order #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	chrome/browser/content_settings/permission_queue_controller.h	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	chrome/browser/geolocation/geolocation_permission_context.cc	View	1	5 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 15 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

Please have a look: adds a call for permissions bubbles to record geolocation setting.

6 years, 5 months ago (2014-06-30 21:30:42 UTC) #1

Michael van Ouwerkerk

lgtm with nit https://codereview.chromium.org/360773003/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc File chrome/browser/geolocation/geolocation_permission_context.cc (right): https://codereview.chromium.org/360773003/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc#newcode37 chrome/browser/geolocation/geolocation_permission_context.cc:37: const GURL& embedder, Nit: move this ...

6 years, 5 months ago (2014-07-01 12:55:59 UTC) #3

Greg Billock

https://codereview.chromium.org/360773003/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc File chrome/browser/geolocation/geolocation_permission_context.cc (right): https://codereview.chromium.org/360773003/diff/1/chrome/browser/geolocation/geolocation_permission_context.cc#newcode37 chrome/browser/geolocation/geolocation_permission_context.cc:37: const GURL& embedder, On 2014/07/01 12:55:59, Michael van Ouwerkerk ...

6 years, 5 months ago (2014-07-01 17:03:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/360773003/20001

6 years, 5 months ago (2014-07-01 17:04:15 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...

6 years, 5 months ago (2014-07-01 21:24:35 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 5 months ago (2014-07-01 21:27:43 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77457)

6 years, 5 months ago (2014-07-01 21:27:44 UTC) #9

Greg Billock

On 2014/07/01 21:27:44, I haz the power (commit-bot) wrote: > Try jobs failed on following ...

6 years, 5 months ago (2014-07-01 23:22:13 UTC) #10

Greg Billock

On 2014/07/01 23:22:13, Greg Billock wrote: > On 2014/07/01 21:27:44, I haz the power (commit-bot) ...

6 years, 5 months ago (2014-07-09 18:49:59 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/360773003/20001

6 years, 5 months ago (2014-07-10 16:53:54 UTC) #14

Message was sent while issue was closed.

Change committed as 282360

Expand Messages | Collapse Messages