Pepper: SelLdrLauncherChrome cleanup.

Pepper: SelLdrLauncherChrome cleanup.

The indirection provided by SelLdrLauncherChrome::Start() isn't much help.
Instead, we just expose the channel so that ServiceRuntime can pass it to
LaunchSelLdr directly.

BUG=239656
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280686

[bbudge, 2014-06-30 18:50:39]

https://codereview.chromium.org/360743002/diff/20001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h (right):

https://codereview.chromium.org/360743002/diff/20001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h:21: NaClHandle*
mutable_channel() { return &channel_; }
It's strange to expose this with a getter here, although another subclass also
does this:
https://code.google.com/p/chromium/codesearch#chromium/src/native_client/src/...

Why not expose it on the base class?

[teravest, 2014-06-30 19:50:41]

On 2014/06/30 18:50:39, bbudge (OOO July 1-8) wrote:
>
https://codereview.chromium.org/360743002/diff/20001/ppapi/native_client/src/...
> File ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h (right):
> 
>
https://codereview.chromium.org/360743002/diff/20001/ppapi/native_client/src/...
> ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h:21:
NaClHandle*
> mutable_channel() { return &channel_; }
> It's strange to expose this with a getter here, although another subclass also
> does this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/native_client/src/...
> 
> Why not expose it on the base class?

I've changed this to have a set_channel() accessor instead.

[bbudge, 2014-06-30 19:53:47]

lgtm

[teravest, 2014-06-30 21:23:11]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-06-30 21:23:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/360743002/40001

[commit-bot: I haz the power, 2014-06-30 22:56:35]

Change committed as 280686