Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 36073007: [Notification] Stop calling detachPresenter(). (Closed)

Created:
7 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[Notification] Stop calling detachPresenter(). It's empty on Blink side now. Rather than implementing it or leave it empty, just stop calling it. In Chromium, content::NotificationProvider never goes away. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233519

Patch Set 1 #

Patch Set 2 : Addressed #3 #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M content/renderer/active_notification_tracker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/active_notification_tracker.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/notification_provider.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tyoshino (SeeGerritForStatus)
Hi John, what do you think about this? Blink side clean up: https://codereview.chromium.org/36823002/
7 years, 2 months ago (2013-10-23 08:54:27 UTC) #1
tyoshino (SeeGerritForStatus)
Hi jam, Could you please review this? johnnyg seems to be no longer actively working ...
7 years, 1 month ago (2013-10-30 09:31:43 UTC) #2
jam
On 2013/10/30 09:31:43, tyoshino wrote: > Hi jam, > > Could you please review this? ...
7 years, 1 month ago (2013-10-30 18:13:58 UTC) #3
tyoshino (SeeGerritForStatus)
On 2013/10/30 18:13:58, jam wrote: > On 2013/10/30 09:31:43, tyoshino wrote: > > Hi jam, ...
7 years, 1 month ago (2013-10-31 09:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/36073007/90001
7 years, 1 month ago (2013-10-31 09:31:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=95653
7 years, 1 month ago (2013-10-31 12:27:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/36073007/90001
7 years, 1 month ago (2013-10-31 13:58:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=95764
7 years, 1 month ago (2013-10-31 17:09:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/36073007/90001
7 years, 1 month ago (2013-11-06 04:45:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94626
7 years, 1 month ago (2013-11-06 08:56:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/36073007/90001
7 years, 1 month ago (2013-11-07 05:53:05 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:58:57 UTC) #12
Message was sent while issue was closed.
Change committed as 233519

Powered by Google App Engine
This is Rietveld 408576698