Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 360693002: Use MEMORY_SANITIZER_INITIAL_SIZE for sanitizer. (Closed)

Created:
6 years, 5 months ago by JungJik
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use MEMORY_SANITIZER_INITIAL_SIZE for sanitizer. Out-of-bounds reads based on pointer access. so the initial size should be 1 at instance time. This patch is related with crrev.com/357603002 and the original issue was crrev.com/22548004. Bug=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
JungJik
PTAL :) I've tested asan with two patches. how could I commit those two patches ...
6 years, 5 months ago (2014-07-01 12:11:52 UTC) #1
abarth-chromium
On 2014/07/01 at 12:11:52, jungjik.lee wrote: > I've tested asan with two patches. > how ...
6 years, 5 months ago (2014-07-01 14:46:40 UTC) #2
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-01 14:46:56 UTC) #3
JungJik
On 2014/07/01 14:46:56, abarth wrote: > LGTM thanks for lgtm :) I appreciate your help.
6 years, 5 months ago (2014-07-01 15:17:46 UTC) #4
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-01 15:17:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/360693002/1
6 years, 5 months ago (2014-07-01 15:18:40 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 19:22:15 UTC) #7
Message was sent while issue was closed.
Change committed as 280862

Powered by Google App Engine
This is Rietveld 408576698