| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 379 | 379 |
| 380 | 380 |
| 381 def _CheckNoDEPSGIT(input_api, output_api): | 381 def _CheckNoDEPSGIT(input_api, output_api): |
| 382 """Make sure .DEPS.git is never modified manually.""" | 382 """Make sure .DEPS.git is never modified manually.""" |
| 383 if any(f.LocalPath().endswith('.DEPS.git') for f in | 383 if any(f.LocalPath().endswith('.DEPS.git') for f in |
| 384 input_api.AffectedFiles()): | 384 input_api.AffectedFiles()): |
| 385 return [output_api.PresubmitError( | 385 return [output_api.PresubmitError( |
| 386 'Never commit changes to .DEPS.git. This file is maintained by an\n' | 386 'Never commit changes to .DEPS.git. This file is maintained by an\n' |
| 387 'automated system based on what\'s in DEPS and your changes will be\n' | 387 'automated system based on what\'s in DEPS and your changes will be\n' |
| 388 'overwritten.\n' | 388 'overwritten.\n' |
| 389 'See http://code.google.com/p/chromium/wiki/UsingNewGit#Rolling_DEPS\n' | 389 'See https://sites.google.com/a/chromium.org/dev/developers/how-tos/get-th
e-code#Rolling_DEPS\n' |
| 390 'for more information')] | 390 'for more information')] |
| 391 return [] | 391 return [] |
| 392 | 392 |
| 393 | 393 |
| 394 def _CheckNoBannedFunctions(input_api, output_api): | 394 def _CheckNoBannedFunctions(input_api, output_api): |
| 395 """Make sure that banned functions are not used.""" | 395 """Make sure that banned functions are not used.""" |
| 396 warnings = [] | 396 warnings = [] |
| 397 errors = [] | 397 errors = [] |
| 398 | 398 |
| 399 file_filter = lambda f: f.LocalPath().endswith(('.mm', '.m', '.h')) | 399 file_filter = lambda f: f.LocalPath().endswith(('.mm', '.m', '.h')) |
| (...skipping 1205 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1605 builders.extend(['cros_x86']) | 1605 builders.extend(['cros_x86']) |
| 1606 | 1606 |
| 1607 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1607 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1608 # unless they're .gyp(i) files as changes to those files can break the gyp | 1608 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1609 # step on that bot. | 1609 # step on that bot. |
| 1610 if (not all(re.search('^chrome', f) for f in files) or | 1610 if (not all(re.search('^chrome', f) for f in files) or |
| 1611 any(re.search('\.gypi?$', f) for f in files)): | 1611 any(re.search('\.gypi?$', f) for f in files)): |
| 1612 builders.extend(['android_aosp']) | 1612 builders.extend(['android_aosp']) |
| 1613 | 1613 |
| 1614 return GetDefaultTryConfigs(builders) | 1614 return GetDefaultTryConfigs(builders) |
| OLD | NEW |