chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html - Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: address comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

diff --git a/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html b/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

new file mode 100644

index 0000000000000000000000000000000000000000..f946bf0e27b62c0a2f62c523062b65c6f474850a

--- /dev/null

+++ b/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

@@ -0,0 +1,17 @@

+<head>

+ <script type="text/javascript">

+var ctrlDown = false;

+document.onkeyup = function(e) {

+ if (e.keyCode == 17)

+ ctrlDown = false;

+document.onkeydown = function(e) {

+ if (e.keyCode == 17)

+ ctrlDown = true;

+ else if (String.fromCharCode(e.keyCode) == 'D' && ctrlDown) {

+ document.body.bgColor = "magenta";

+ return false;

+ }

+};

+ </script>

+</head>

« chrome/browser/ui/extensions/accelerator_priority.cc ('K') | « chrome/chrome_browser_ui.gypi ('k') | no next file » | no next file with comments »