chrome/browser/extensions/extension_keybinding_registry.h - Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.h

Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: update test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc » ('j') | chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_keybinding_registry.h

diff --git a/chrome/browser/extensions/extension_keybinding_registry.h b/chrome/browser/extensions/extension_keybinding_registry.h

index 1fb656cffa997769f053358af2cbc09916534f44..443cbcf55f43324702b08a96a03c1cf75747613d 100644

--- a/chrome/browser/extensions/extension_keybinding_registry.h

+++ b/chrome/browser/extensions/extension_keybinding_registry.h

@@ -121,6 +121,8 @@ class ExtensionKeybindingRegistry : public content::NotificationObserver,

// Returns true if the |event_targets_| is empty; otherwise returns false.

bool IsEventTargetsEmpty() const;

+ content::BrowserContext* browser_context() const { return browser_context_; }

Finnur 2014/07/02 11:56:16 nit: doc.

Mike Wittman 2014/07/02 21:56:19 Done.

private:

// Overridden from content::NotificationObserver:

virtual void Observe(int type,