Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6515)

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_view.cc

Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_action_view.cc b/chrome/browser/ui/views/toolbar/browser_action_view.cc
index 5e2ae578e1e1f1ce5fe22bbeec86cd83edcdf6a8..772a4056b9c3cf2bfbfdaa8219fee267fafca302 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/browser_action_view.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/extensions/accelerator_priority.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
@@ -378,6 +379,12 @@ scoped_ptr<LabelButtonBorder> BrowserActionButton::CreateDefaultBorder() const {
bool BrowserActionButton::AcceleratorPressed(
const ui::Accelerator& accelerator) {
+ // Normal priority shortcuts must be handled via standard browser commands to
+ // be processed at the proper time.
+ if (GetAcceleratorPriority(accelerator, extension_) ==
+ ui::AcceleratorManager::kNormalPriority)
+ return false;
+
delegate_->OnBrowserActionExecuted(this);
return true;
}
@@ -424,7 +431,10 @@ void BrowserActionButton::MaybeRegisterExtensionCommand() {
keybinding_.reset(new ui::Accelerator(
browser_action_command.accelerator()));
GetFocusManager()->RegisterAccelerator(
- *keybinding_.get(), ui::AcceleratorManager::kHighPriority, this);
+ *keybinding_.get(),
+ GetAcceleratorPriority(browser_action_command.accelerator(),
+ extension_),
+ this);
}
}
« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698