Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4485)

Unified Diff: chrome/browser/ui/extensions/accelerator_priority.h

Issue 360423002: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/accelerator_priority.h
diff --git a/chrome/browser/ui/extensions/accelerator_priority.h b/chrome/browser/ui/extensions/accelerator_priority.h
new file mode 100644
index 0000000000000000000000000000000000000000..0908d125cc898f970e66363cd9daa6c386c282af
--- /dev/null
+++ b/chrome/browser/ui/extensions/accelerator_priority.h
@@ -0,0 +1,47 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// The accelerator priority functions are intended to distinguish between
+// accelerators that should preserve the built-in Chrome keybinding semantics
+// (normal) and accelerators that should always override web page key handling
+// (high). High priority is used for all accelerators assigned to extensions,
+// except for the Ctrl+D bookmarking shortcut which is assigned normal priority
+// when bound by an extension that requests the privilege to override the
+// bookmark UI. This is currently the only case where we allow an extension to
+// replace a built-in Chrome accelerator, and it should have the same behavior
+// as the built-in accelerator.
+
+#ifndef CHROME_BROWSER_UI_EXTENSIONS_ACCELERATOR_PRIORITY_H_
+#define CHROME_BROWSER_UI_EXTENSIONS_ACCELERATOR_PRIORITY_H_
+
+#include <string>
+
+#include "ui/base/accelerators/accelerator_manager.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+class Extension;
+}
+
+namespace ui {
+class Accelerator;
+}
+
+// Returns the registration priority to be used when registering |accelerator|
+// for |extension|.
+ui::AcceleratorManager::HandlerPriority GetAcceleratorPriority(
+ const ui::Accelerator& accelerator,
+ const extensions::Extension* extension);
+
+// Returns the registration priority to be used when registering |accelerator|
+// for the extension with ID |extension_id|.
+ui::AcceleratorManager::HandlerPriority GetAcceleratorPriorityById(
+ const ui::Accelerator& accelerator,
+ const std::string& extension_id,
+ content::BrowserContext* browser_context);
+
+#endif // CHROME_BROWSER_UI_EXTENSIONS_ACCELERATOR_PRIORITY_H_
« no previous file with comments | « chrome/browser/extensions/extension_keybinding_registry.h ('k') | chrome/browser/ui/extensions/accelerator_priority.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698