cr_cronet - simple cr-like wrapper to help with cronet builds.

cr_cronet - simple cr-like wrapper to help with cronet builds.

BUG=390267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282341

[mef, 2014-07-07 16:17:05]

Hi,

I'm not sure whether this is worth landing, but this is a simple script to
simplify typical operations that I do during cronet development.

WDYT?

[mmenke, 2014-07-07 17:05:20]

I'm on the fence about landing it, though nice to have all the GYP defines in
one place.

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:26: return run ('GYP_DEFINES="OS=android
enable_websockets=0 disable_file_support=1 disable_ftp_support=1
use_icu_alternatives_on_android=1" gclient runhooks')
Should the first part of this also be run before syncing?  Then you wouldn't
have to run init before (Or after) sync.  The extra "gclient runhooks" is pretty
slow.

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:36: #parser.print_help()
This should be fixed (Get rid of it, make it work and uncomment it, or
something).

[miloslav, 2014-07-09 09:52:51]

I also think it would be helpful to have all the defines and commands in one
place.

[mef, 2014-07-09 13:43:53]

Thanks for feedback!

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:26: return run ('GYP_DEFINES="OS=android
enable_websockets=0 disable_file_support=1 disable_ftp_support=1
use_icu_alternatives_on_android=1" gclient runhooks')
On 2014/07/07 17:05:20, mmenke wrote:
> Should the first part of this also be run before syncing?  Then you wouldn't
> have to run init before (Or after) sync.  The extra "gclient runhooks" is
pretty
> slow.

Done.

https://codereview.chromium.org/360403002/diff/1/components/cronet/tools/cr_c...
components/cronet/tools/cr_cronet.py:36: #parser.print_help()
On 2014/07/07 17:05:20, mmenke wrote:
> This should be fixed (Get rid of it, make it work and uncomment it, or
> something).

Done.

[mmenke, 2014-07-09 14:23:05]

https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
components/cronet/tools/cr_cronet.py:39: return run (gyp_defines + ' gclient
sync')
What happens if the rebase fails or there's a merge conflict?

[mef, 2014-07-09 15:18:26]

https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
components/cronet/tools/cr_cronet.py:39: return run (gyp_defines + ' gclient
sync')
On 2014/07/09 14:23:05, mmenke wrote:
> What happens if the rebase fails or there's a merge conflict?
It still does the gclient sync. I guess this is wrong. Done.

[mmenke, 2014-07-09 15:20:15]

On 2014/07/09 15:18:26, mef wrote:
>
https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
> File components/cronet/tools/cr_cronet.py (right):
> 
>
https://codereview.chromium.org/360403002/diff/20001/components/cronet/tools/...
> components/cronet/tools/cr_cronet.py:39: return run (gyp_defines + ' gclient
> sync')
> On 2014/07/09 14:23:05, mmenke wrote:
> > What happens if the rebase fails or there's a merge conflict?
> It still does the gclient sync. I guess this is wrong. Done.

LGTM!

[mef, 2014-07-10 09:09:22]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-07-10 09:09:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/360403002/40001

[commit-bot: I haz the power, 2014-07-10 13:01:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-10 16:13:01]

Change committed as 282341