Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 360373004: Revert 221427 "Add instrumentation to the MessagePumpMac family ..." (Closed)

Created:
6 years, 5 months ago by Robert Sesek
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Project:
chromium
Visibility:
Public.

Description

Revert 221427 "Add instrumentation to the MessagePumpMac family ..." This code is no longer needed, since the experiment is not viable. > Add instrumentation to the MessagePumpMac family of classes. > > This adds UMA-uploaded histograms of sampling intervals for key points of data: > * Total time spent in a CFRunLoop > * Total time waiting in CFRunLoop > * Total time servicing MessagePump::Delegate (the MessageLoop) > * The MessageLoop queue size and queueing delay before servicing > > It adds 1 second sampling for 15 seconds at startup, only for the main thread > (NSApplication-based) run loops. > > The data will be used to determine if adding scheduling-like behavior to the > MessagePump will result in more efficient processing of the MessageLoop work. > > An unforunate side effect of this change is exposing another method on the > MessagePump::Delegate interface, but there does not appear to be a better way > to do this. > > BUG=264886 > R=jar@chromium.org, mark@chromium.org > > Review URL: https://codereview.chromium.org/22911026 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -307 lines) Patch
M base/message_loop/message_loop.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M base/message_loop/message_pump.h View 2 chunks +0 lines, -14 lines 0 comments Download
M base/message_loop/message_pump_mac.h View 4 chunks +7 lines, -13 lines 0 comments Download
M base/message_loop/message_pump_mac.mm View 12 chunks +8 lines, -264 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 5 months ago (2014-07-01 21:44:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/360373004/1
6 years, 5 months ago (2014-07-01 21:44:56 UTC) #2
commit-bot: I haz the power
Change committed as 280939
6 years, 5 months ago (2014-07-02 02:04:01 UTC) #3
tzik
6 years, 5 months ago (2014-07-02 03:29:41 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698