Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 360363002: Adding a performance test for font fallback (Closed)

Created:
6 years, 5 months ago by Dominik Röttsches
Modified:
6 years, 5 months ago
Reviewers:
eseidel, eae, behdad
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@benchmarkBefore
Project:
blink
Visibility:
Public.

Description

Adding a performance test for font fallback Using a set of ~19000 characters extracted from DRT's font configuration, the test is slicing them into smaller sets and rendering them in a page. This exercises WebFontInfo::fallbackFontForChar which is the cause for slowness, as described in bug 266214. This test case is preparation for landing the an optimization patch which drastically reduces the number of fontconfig calls in the sandbox IPC process. BUG=266214 R=eseidel,eae Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2556 lines, -0 lines) Patch
A PerformanceTests/Layout/character_fallback.html View 1 chunk +12 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/resources/character_fallback_chars.js View 1 chunk +2510 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/resources/character_fallback_test.js View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dominik Röttsches
Using this test case, we can measure the cold start improvements of https://codereview.chromium.org/342823005/ quite well. ...
6 years, 5 months ago (2014-07-01 20:29:25 UTC) #1
eae
LGTM
6 years, 5 months ago (2014-07-01 20:49:42 UTC) #2
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-01 21:17:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/360363002/1
6 years, 5 months ago (2014-07-01 21:17:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-01 22:21:13 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 23:53:26 UTC) #6
Message was sent while issue was closed.
Change committed as 177337

Powered by Google App Engine
This is Rietveld 408576698