Issue 360353002: Move core/WebCorePrefixMac.h to build/mac/Prefix.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360353002: Move core/WebCorePrefixMac.h to build/mac/Prefix.h (Closed)

Created:
6 years, 5 months ago by lgombos

Modified:
6 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Move core/WebCorePrefixMac.h to build/mac/Prefix.h to make it a top level build prefix. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177333

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -111 lines)			Patch
A +	Source/build/mac/Prefix.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/config.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/WebCorePrefixMac.h	View		1 chunk	+0 lines, -105 lines	0 comments	Download
M	Source/core/core.gyp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/platform/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/blink_platform.gyp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

lgombos

My motivation here is just to move WebCorePrefixMac.h to its proper place. I am sure ...

6 years, 5 months ago (2014-07-01 18:22:05 UTC) #1

abarth-chromium

LGTM I tried this before and wasn't able to make it work for some reason.

6 years, 5 months ago (2014-07-01 20:05:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/360353002/20001

6 years, 5 months ago (2014-07-01 20:15:06 UTC) #4

Message was sent while issue was closed.

Change committed as 177333