Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 360343002: PasswordStoreMac::RemoveLoginsCreatedBetween() shouldn't affect other profiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove GetUnusedKeychainForms() + typos Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index ac6bd0be6349d353d8421c7854e40c7a197d4b7f..b3b09389219eac0e8298fcaa08fc5ae242c02858 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -62,13 +62,13 @@ class LoginDatabase {
// Loads a list of matching password forms into the specified vector |forms|.
// The list will contain all possibly relevant entries to the observed |form|,
- // including blacklisted matches.
+ // including blacklisted matches. The caller owns |forms| after the call.
bool GetLogins(const autofill::PasswordForm& form,
std::vector<autofill::PasswordForm*>* forms) const;
// Loads all logins created from |begin| onwards (inclusive) and before |end|.
// You may use a null Time value to do an unbounded search in either
- // direction.
+ // direction. The caller owns |forms| after the call.
bool GetLoginsCreatedBetween(
base::Time begin,
base::Time end,
@@ -76,18 +76,19 @@ class LoginDatabase {
// Loads all logins synced from |begin| onwards (inclusive) and before |end|.
// You may use a null Time value to do an unbounded search in either
- // direction.
+ // direction. The caller owns |forms| after the call.
bool GetLoginsSyncedBetween(
base::Time begin,
base::Time end,
std::vector<autofill::PasswordForm*>* forms) const;
// Loads the complete list of autofillable password forms (i.e., not blacklist
- // entries) into |forms|.
+ // entries) into |forms|. The caller owns |forms| after the call.
bool GetAutofillableLogins(
std::vector<autofill::PasswordForm*>* forms) const;
- // Loads the complete list of blacklist forms into |forms|.
+ // Loads the complete list of blacklist forms into |forms|. The caller owns
+ // |forms| after the call.
bool GetBlacklistLogins(
std::vector<autofill::PasswordForm*>* forms) const;
« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698