Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 36033003: Notify WebSocket connection failure, Blink side (Closed)

Created:
7 years, 2 months ago by yhirano
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Notify WebSocket connection failure, Blink side In order to set |wasClean| property of CloseEvent and show the failure message correctly, The blink-side WebSocket need to know whether the connection is dropped because of a server request. chromium side change is: https://codereview.chromium.org/34753008/ BUG=310405 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161135

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 5

Patch Set 6 : rebase #

Patch Set 7 : #

Patch Set 8 : rebase #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +14 lines, -4 lines 0 comments Download
M public/platform/WebSocketHandleClient.h View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
yhirano
7 years, 2 months ago (2013-10-23 02:25:07 UTC) #1
abarth-chromium
https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h File public/platform/WebSocketHandleClient.h (right): https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h#newcode50 public/platform/WebSocketHandleClient.h:50: virtual void didFail(WebSocketHandle*, const WebString& message) = 0; Why ...
7 years, 2 months ago (2013-10-23 18:26:23 UTC) #2
yhirano
https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h File public/platform/WebSocketHandleClient.h (right): https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h#newcode50 public/platform/WebSocketHandleClient.h:50: virtual void didFail(WebSocketHandle*, const WebString& message) = 0; On ...
7 years, 2 months ago (2013-10-24 00:43:32 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h File public/platform/WebSocketHandleClient.h (right): https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h#newcode63 public/platform/WebSocketHandleClient.h:63: virtual void didClose(WebSocketHandle*, bool fail, unsigned short code, const ...
7 years, 2 months ago (2013-10-24 09:08:43 UTC) #4
yhirano
https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h File public/platform/WebSocketHandleClient.h (right): https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h#newcode63 public/platform/WebSocketHandleClient.h:63: virtual void didClose(WebSocketHandle*, bool fail, unsigned short code, const ...
7 years, 2 months ago (2013-10-24 09:11:35 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm
7 years, 2 months ago (2013-10-25 05:52:52 UTC) #6
yhirano
abarth@, PTAL https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h File public/platform/WebSocketHandleClient.h (right): https://codereview.chromium.org/36033003/diff/210001/public/platform/WebSocketHandleClient.h#newcode50 public/platform/WebSocketHandleClient.h:50: virtual void didFail(WebSocketHandle*, const WebString& message) = ...
7 years, 1 month ago (2013-10-31 03:34:50 UTC) #7
abarth-chromium
lgtm https://codereview.chromium.org/36033003/diff/410001/Source/modules/websockets/NewWebSocketChannelImpl.cpp File Source/modules/websockets/NewWebSocketChannelImpl.cpp (right): https://codereview.chromium.org/36033003/diff/410001/Source/modules/websockets/NewWebSocketChannelImpl.cpp#newcode394 Source/modules/websockets/NewWebSocketChannelImpl.cpp:394: const unsigned short abnormalClosure = 1006; Where does ...
7 years, 1 month ago (2013-10-31 17:54:48 UTC) #8
yhirano
https://codereview.chromium.org/36033003/diff/410001/Source/modules/websockets/NewWebSocketChannelImpl.cpp File Source/modules/websockets/NewWebSocketChannelImpl.cpp (right): https://codereview.chromium.org/36033003/diff/410001/Source/modules/websockets/NewWebSocketChannelImpl.cpp#newcode394 Source/modules/websockets/NewWebSocketChannelImpl.cpp:394: const unsigned short abnormalClosure = 1006; On 2013/10/31 17:54:49, ...
7 years, 1 month ago (2013-11-01 03:51:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/36033003/480001
7 years, 1 month ago (2013-11-01 03:53:16 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 05:04:49 UTC) #11
Message was sent while issue was closed. 
Change committed as 161135

Powered by Google App Engine
This is Rietveld 408576698