Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 360273002: Fix building pdfium for x64 with ninja under windows. (Closed)

Created:
6 years, 5 months ago by mdoppler
Modified:
6 years, 5 months ago
Reviewers:
jschuh, Nico, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Visibility:
Public.

Description

Fix building pdfium for x64 with ninja under windows. This adds the necessary directives to the standalone gyp file. R=jschuh@chromium.org, jam@chromium.org BUG=pdfium:22 Patch from Michael Doppler <m.doppler@gmail.com>;. Committed: https://pdfium.googlesource.com/pdfium/+/c7cd3c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mdoppler
6 years, 5 months ago (2014-07-01 11:38:17 UTC) #1
mdoppler
This fixes pdfium issue 22: https://code.google.com/p/pdfium/issues/detail?id=22
6 years, 5 months ago (2014-07-01 11:39:46 UTC) #2
jschuh
lgtm
6 years, 5 months ago (2014-07-02 17:21:11 UTC) #3
Nico
Did anyone land this?
6 years, 5 months ago (2014-07-16 22:50:58 UTC) #4
mdoppler
On 2014/07/16 22:50:58, Nico (away) wrote: > Did anyone land this? I don't think so, ...
6 years, 5 months ago (2014-07-17 06:17:50 UTC) #5
Nico
Committed patchset #1 manually as rc7cd3c8 (presubmit successful).
6 years, 5 months ago (2014-07-17 16:02:24 UTC) #6
Nico
On 2014/07/17 06:17:50, mdoppler wrote: > On 2014/07/16 22:50:58, Nico (away) wrote: > > Did ...
6 years, 5 months ago (2014-07-17 16:03:44 UTC) #7
mdoppler
6 years, 5 months ago (2014-07-17 16:24:35 UTC) #8
Message was sent while issue was closed.
On 2014/07/17 16:03:44, Nico (away) wrote:
> On 2014/07/17 06:17:50, mdoppler wrote:
> > On 2014/07/16 22:50:58, Nico (away) wrote:
> > > Did anyone land this?
> > 
> > I don't think so,  should I ask one of the pdfium devs to land it?
> 
> I just committed it for you. Unless you say "Please land" somewhere, your
> reviewer might not expect you to expect them to land your patches and they
might
> be forgotten – so if your patch doesn't get landed within a day of getting an
> lgtm, it's best to ping.
> 
> Thanks for the patch!

I see, thanks for landing it!

Powered by Google App Engine
This is Rietveld 408576698