Issue 360203002: Disable SVG Fonts in CSS on all platforms except GDI Windows (XP, Vista)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 360203002: Disable SVG Fonts in CSS on all platforms except GDI Windows (XP, Vista) (Closed)

Created:
6 years, 5 months ago by pdr.

Modified:
6 years, 5 months ago

Reviewers:
eae, eseidel

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Disable SVG Fonts in CSS on all platforms except GDI Windows (XP, Vista) This patch disables SVG fonts everywhere except GDI platforms, per [1]. The patch itself is straightforward: the SVGFontsOnNonGDIPlatforms runtime enabled feature has been added but is disabled by default. TestExpectations has been updated with the usual mass of rebaselines. coords-dom-02-f.svg has been marked as no longer failing. A brand new test has been added to test the fallback code. This test is marked as failing on XP (we have no Vista bots). [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/pYbbUcYvlYY/LQvFvM8KZZEJ BUG=242735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177785

Patch Set 1 #

Patch Set 2 : Update expectations, add a test, fix a compile #

Patch Set 3 : Remove svg/custom/acid3-test-77.html change #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -4 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2	2 chunks	+52 lines, -1 line	0 comments	Download
A	LayoutTests/svg/custom/svg-font-support.html	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/custom/svg-font-support-expected.html	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSFontFaceSrcValue.cpp	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pdr.

Ready for an initial review (still pending API owner approval).

6 years, 5 months ago (2014-07-01 05:56:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/360203002/40001

6 years, 5 months ago (2014-07-09 22:55:19 UTC) #4

Message was sent while issue was closed.

Change committed as 177785

Expand Messages | Collapse Messages