Add header pointer to BeforeProxyHeadersSentCallback

Add header pointer to BeforeProxyHeadersSentCallback

This is needed because the higher layers, e.g., UrlRequestHttpJob
do not always have a pointer to the request headers that the
HttpNetworkTransaction will actually send. Note that the old code
could also pass the wrong headers if redirects resulted in no longer
going through the proxy.

BUG=345907
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280885

[mmenke, 2014-07-01 18:08:54]

LGTM, modulo comment.  Suggest mentioning in the description that the old code
could also pass the wrong headers if redirects resulted in no longer going
through the proxy.

https://codereview.chromium.org/360113004/diff/20001/net/http/http_network_tr...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/360113004/diff/20001/net/http/http_network_tr...
net/http/http_network_transaction.cc:888:
before_proxy_headers_sent_callback_.Run(proxy_info_, &request_headers_);
Should move this below "request_headers_.MergeFrom(request_->extra_headers);"

[bengr, 2014-07-01 18:18:51]

https://codereview.chromium.org/360113004/diff/20001/net/http/http_network_tr...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/360113004/diff/20001/net/http/http_network_tr...
net/http/http_network_transaction.cc:888:
before_proxy_headers_sent_callback_.Run(proxy_info_, &request_headers_);
On 2014/07/01 18:08:54, mmenke wrote:
> Should move this below "request_headers_.MergeFrom(request_->extra_headers);"

Done.

[bengr, 2014-07-01 18:18:59]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-01 18:19:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/360113004/40001

[commit-bot: I haz the power, 2014-07-01 21:20:28]

Change committed as 280885