Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: Source/core/rendering/style/StyleDifference.h

Issue 360103008: Remove dead StyleDifference::needsRecompositeLayer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/style/RenderStyle.cpp ('k') | Source/core/rendering/svg/RenderSVGGradientStop.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/StyleDifference.h
diff --git a/Source/core/rendering/style/StyleDifference.h b/Source/core/rendering/style/StyleDifference.h
index d8418217b83d1c2df5ea89799ae9f084854fa04b..36e267288c2f7f97b9f9866c19d1382566c4c2aa 100644
--- a/Source/core/rendering/style/StyleDifference.h
+++ b/Source/core/rendering/style/StyleDifference.h
@@ -9,24 +9,14 @@
namespace WebCore {
-// This class represents the difference between two computed styles (RenderStyle).
-// The difference can be combination of 3 types according to the actions needed:
-// - Difference needing layout
-// - Difference needing repaint
-// - Difference needing recompositing layers
class StyleDifference {
public:
StyleDifference()
- : m_needsRecompositeLayer(false)
- , m_repaintType(NoRepaint)
- , m_layoutType(NoLayout) { }
+ : m_repaintType(NoRepaint)
+ , m_layoutType(NoLayout)
+ { }
- // The two styles are identical.
- bool hasNoChange() const { return !m_needsRecompositeLayer && !m_repaintType && !m_layoutType; }
-
- // The layer needs its position and transform updated. Implied by other repaint and layout flags.
- bool needsRecompositeLayer() const { return m_needsRecompositeLayer || needsRepaint() || needsLayout(); }
- void setNeedsRecompositeLayer() { m_needsRecompositeLayer = true; }
+ bool hasDifference() const { return m_repaintType || m_layoutType; }
bool needsRepaint() const { return m_repaintType != NoRepaint; }
void clearNeedsRepaint() { m_repaintType = NoRepaint; }
@@ -58,8 +48,6 @@ public:
void setNeedsFullLayout() { m_layoutType = FullLayout; }
private:
- unsigned m_needsRecompositeLayer : 1;
-
enum RepaintType {
NoRepaint = 0,
RepaintObject,
« no previous file with comments | « Source/core/rendering/style/RenderStyle.cpp ('k') | Source/core/rendering/svg/RenderSVGGradientStop.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698