Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 360103003: Test adding a <source> element after removing a failed candidate (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Test adding a <source> element after removing a failed candidate Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A LayoutTests/media/video-source-add-after-remove.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/media/video-source-add-after-remove-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL, as discussed in https://codereview.chromium.org/349973006/
6 years, 5 months ago (2014-06-30 21:56:08 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 5 months ago (2014-06-30 22:34:58 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-06-30 22:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/360103003/1
6 years, 5 months ago (2014-06-30 22:44:11 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 23:38:15 UTC) #5
Message was sent while issue was closed.
Change committed as 177255

Powered by Google App Engine
This is Rietveld 408576698