Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 360053002: Revert of DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it. (Closed)

Created:
6 years, 5 months ago by loislo
Modified:
6 years, 5 months ago
Reviewers:
aandrey, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it. (https://codereview.chromium.org/342713002/) Reason for revert: live-edit.html is failing in a batch of tests. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showLargeExpectations=true&showExpectations=true&tests=inspector%2Fsources%2Fdebugger%2Flive-edit.html Original issue's description: > DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it. > > BUG=267592 > R=yurys, pfeldman@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177170 TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=267592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -162 lines) Patch
D LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html View 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/frameworks-step-from-framework-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/resources/framework.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 11 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
loislo
Created Revert of DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it.
6 years, 5 months ago (2014-06-30 16:14:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/360053002/1
6 years, 5 months ago (2014-06-30 16:15:19 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 16:15:52 UTC) #3
Message was sent while issue was closed.
Change committed as 177214

Powered by Google App Engine
This is Rietveld 408576698