wm: Add two pass rendering to OpenGL|ES backend.

wm: Add two pass rendering to OpenGL|ES backend.

TEST=Run on tegra2_seaboard
BUG=None

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b9b8886

[Daniel Erat, 2010-09-30 00:35:45]

LGTM

http://codereview.chromium.org/3599002/diff/1/3
File gles/opengles_visitor.cc (right):

http://codereview.chromium.org/3599002/diff/1/3#newcode40
gles/opengles_visitor.cc:40: : gles_visitor_(gles_visitor) {}
add a virtual d'tor (ditto for TransparentPass and OpaquePass)

http://codereview.chromium.org/3599002/diff/1/3#newcode49
gles/opengles_visitor.cc:49: protected:
fix indenting: "protected" should be indented one space, the next line should be
indented one further

[Greg Spencer (Chromium), 2010-09-30 01:55:13]

Looks good to me.

[Kenneth Waters, 2010-09-30 17:22:40]

http://codereview.chromium.org/3599002/diff/1/3
File gles/opengles_visitor.cc (right):

http://codereview.chromium.org/3599002/diff/1/3#newcode40
gles/opengles_visitor.cc:40: : gles_visitor_(gles_visitor) {}
On 2010/09/30 00:35:45, Daniel Erat wrote:
> add a virtual d'tor (ditto for TransparentPass and OpaquePass)

Is this a style thing?  I thought since the base class had a virtual dtor that
this worked correctly.  Am I mistaken?

[Daniel Erat, 2010-09-30 17:37:20]

http://codereview.chromium.org/3599002/diff/1/3
File gles/opengles_visitor.cc (right):

http://codereview.chromium.org/3599002/diff/1/3#newcode40
gles/opengles_visitor.cc:40: : gles_visitor_(gles_visitor) {}
On 2010/09/30 17:22:40, Kenneth Waters wrote:
> On 2010/09/30 00:35:45, Daniel Erat wrote:
> > add a virtual d'tor (ditto for TransparentPass and OpaquePass)
> 
> Is this a style thing?  I thought since the base class had a virtual dtor that
> this worked correctly.  Am I mistaken?

I think that it's good to include a virtual destructor for any class that's
derived by another class (or is likely to be derived by another class in the
future).  Technically, you only need it for BasePass if you're going to do
something like:

BasePass* pass = new TransparentPass(...);
delete pass;

, but I don't think that it hurts to always include it when using inheritance to
be on the safe side.

[Greg Spencer (Chromium), 2010-09-30 17:39:26]

On 2010/09/30 17:37:20, Daniel Erat wrote:
> I don't think that it hurts to always include it when using 
> inheritance to be on the safe side.

It's an interpretation of the rule:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Inheri...

to include virtual destructors.