Issue 359823002: Deleted unneeded enums from HandshakeFailureReason.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 359823002: Deleted unneeded enums from HandshakeFailureReason. (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Deleted unneeded enums from HandshakeFailureReason. Updated the comments for enums. Replaced CLIENT_NONCE_UNKNOWN_FAILURE with CLIENT_NONCE_INVALID_FAILURE. In CL: 69888738, replaced usage of CLIENT_NONCE_UNKNOWN_FAILURE with the correct reason. Fixed comments from wtc in CLs: 69773346, 69963869 Minor cleanup of code. Merge internal change: 70135161 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -36 lines)			Patch
M	net/quic/crypto/crypto_handshake.h	View	2 chunks	+28 lines, -31 lines	0 comments	Download
M	net/quic/crypto/crypto_server_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_server_config.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

6 years, 5 months ago (2014-07-01 00:47:48 UTC) #3

Message was sent while issue was closed.

Patch set 1 LGTM.

Raman: let's sit down together tomorrow (Tuesday) to go through this CL and make
sure every failure reason matches an error return in the code.

Expand Messages | Collapse Messages