Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Issue 359803002: net: add HSTS and pinning for Dropbox. (Closed)

Created:
6 years, 5 months ago by agl
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, palmer
Project:
chromium
Visibility:
Public.

Description

net: add HSTS and pinning for Dropbox. BUG=none R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281103

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -0 lines) Patch
M net/http/transport_security_state.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.h View 1 3 chunks +60 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.certs View 1 chunk +195 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 chunks +25 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
agl
palmer: I've confirmed this with Dropbox.
6 years, 5 months ago (2014-06-30 22:12:15 UTC) #1
agl
(rsleevi rather than palmer as the latter is away.)
6 years, 5 months ago (2014-06-30 23:42:16 UTC) #2
Ryan Sleevi
Also away, but LGTM :) https://codereview.chromium.org/359803002/diff/20001/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/359803002/diff/20001/net/http/transport_security_state_static.json#newcode813 net/http/transport_security_state_static.json:813: { "name": "www.dropbox.com", "include_subdomains": ...
6 years, 5 months ago (2014-07-01 03:03:58 UTC) #3
agl
The CQ bit was checked by agl@chromium.org
6 years, 5 months ago (2014-07-01 18:59:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/359803002/20001
6 years, 5 months ago (2014-07-01 19:01:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 22:49:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 22:52:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77472)
6 years, 5 months ago (2014-07-01 22:52:20 UTC) #8
agl
6 years, 5 months ago (2014-07-02 22:19:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r281103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698