Fix the default timezone detection in ICU....

Fix the default timezone detection in ICU.

This is the second patch for this issue. The previous patch was incomplete
in that if a match was found for /etc/locatime in 'posix' directory under
/usr/share/zoneinfo (say, posix/America/New_York)
instead of at the top-level in /usr/share/zoneinfo (say, America/New_York),
the DST offset is set to 0 while the raw-offset is set correctly.

This leads the history and file:// to show the time stamp one hour behind
the 'wall-clock time' when the DST is in effect.

The upstream bug is http://bugs.icu-project.org/trac/ticket/8014


BUG=38632
TEST=1. Make a file locally and open the directory with the file when
daylight saving time is in effect. The time stamp should match that of
'ls' command.
2. Visit a web page and open up the history tab and see the entry has
the correct time stamp instead of time stamp 1-hr behind when daylight
saving time is in effect.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62048

[Evan Martin, 2010-10-08 22:00:14]

The code LGTM, minor suggestion inside (maybe just for when the patch lands
upstream)

http://codereview.chromium.org/3598015/diff/9001/10002
File third_party/icu/patches/linuxtz3.patch (right):

http://codereview.chromium.org/3598015/diff/9001/10002#newcode22
third_party/icu/patches/linuxtz3.patch:22: +static void removeZoneIDPrefix(const
char** id) {
"skip" might be a better verb than "remove", as the latter indicates that it's
modifying the argument, but you're just advancing the pointer here.