Include stlport through -isystem instead of -I.

Include stlport through -isystem instead of -I.

Enables removing a TODO and is needed for the bug linked below.

(Doesn't work for the webkit build for some reason, but that's currently
not built with clang anyhow.)

BUG=381053
R=cjhopman@chromium.org
TBR=brettw@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280406

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282046

[cjhopman, 2014-06-27 20:18:58]

lgtm

https://codereview.chromium.org/359783005/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/359783005/diff/20001/build/common.gypi#newcod...
build/common.gypi:4418: '-I<(android_src)/external/stlport/stlport',
I'm curious why changing these failed on android_aosp. It doesn't look like they
use the 4.4.3 toolchain, so the comment above doesn't apply.

[Nico, 2014-06-27 20:33:04]

On 2014/06/27 20:18:58, cjhopman wrote:
> lgtm
> 
> https://codereview.chromium.org/359783005/diff/20001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/359783005/diff/20001/build/common.gypi#newcod...
> build/common.gypi:4418: '-I<(android_src)/external/stlport/stlport',
> I'm curious why changing these failed on android_aosp. It doesn't look like
they
> use the 4.4.3 toolchain, so the comment above doesn't apply.

Patch set 1 has a failing trybot (
http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...
). I didn't look in detail; it's probably maybe hopefully fixable somehow.

[Nico, 2014-06-27 20:36:26]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-06-27 20:37:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/359783005/40001

[commit-bot: I haz the power, 2014-06-27 20:44:04]

Change committed as 280406

[Anton, 2014-06-30 17:05:50]

A revert of this CL has been created in
https://codereview.chromium.org/330873004/ by anton@chromium.org.

The reason for reverting is: This patch breaks Android Goma builds (the build
continues locally very slowly).

https://groups.google.com/a/google.com/forum/#!topic/goma-users/KNsshiobTvE
.

[Nico, 2014-07-09 15:25:35]

Goma team tells me that this is working now, so I'm going to reland this.

[Nico, 2014-07-09 15:50:39]

Committed patchset #3 manually as r282046 (presubmit successful).