Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 359783002: Improve rejection test for character-based SVG text queries (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Improve rejection test for character-based SVG text queries Perform an intersection of the involved ranges to reject fragments early, while still avoiding calls to mapStartEndPositionsIntoFragmentCoordinates. This means the "cache" added in https://codereview.chromium.org/349223003 can be dropped, since we'll now never even reach it. This gives a moderate speed-up - a few percent - on the original TC compared to using the cache. BUG=267504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -36 lines) Patch
M Source/core/rendering/svg/SVGTextQuery.cpp View 5 chunks +16 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
Previously, on issue 267504: The protagonist adds a cache for ligature adjustment. In this episode: ...
6 years, 5 months ago (2014-06-27 15:44:03 UTC) #1
pdr.
On 2014/06/27 15:44:03, fs wrote: > Previously, on issue 267504: The protagonist adds a cache ...
6 years, 5 months ago (2014-06-27 22:38:32 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-06-27 22:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/359783002/1
6 years, 5 months ago (2014-06-27 22:38:58 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 22:41:59 UTC) #5
Message was sent while issue was closed.
Change committed as 177148

Powered by Google App Engine
This is Rietveld 408576698