Issue 359773002: Mark SkBBoxHierarchyRecord destructor as virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 359773002: Mark SkBBoxHierarchyRecord destructor as virtual (Closed)

Created:
6 years, 5 months ago by Tom Hudson

Modified:
6 years, 5 months ago

Reviewers:
mtklein, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Mark SkBBoxHierarchyRecord destructor as virtual Immediate parent classes have empty virtual destructors, but farther up the inheritance tree there is complicated destruction going on. This change may be unnecessary but makes the polymorphism explicit. BUG=skia:1734 R=mtklein Committed: https://skia.googlesource.com/skia/+/a8377402ee626bd0a6c61ef9f0c256f06eca5759

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/core/SkBBoxHierarchyRecord.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/359773002/1

6 years, 5 months ago (2014-06-27 15:03:54 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-06-27 15:19:39 UTC) #5

Message was sent while issue was closed.

Change committed as a8377402ee626bd0a6c61ef9f0c256f06eca5759

Expand Messages | Collapse Messages