Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 359763002: IDL: Avoid double type-check for variadic interface type arguments (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Avoid double type-check for variadic interface type arguments With [TypeChecking=Interface], two type-checks would be emitted for variadic arguments; one as if the argument wasn't variadic, checking only the first actual argument, and then another one checking each actual argument. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177094

Patch Set 1 : add testcase #

Patch Set 2 : the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M Source/bindings/templates/methods.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
PTAL Another unexpected CG change noticed when adding [TypeChecking=Interface] on the Document interface, affecting the ...
6 years, 5 months ago (2014-06-27 10:47:27 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-06-27 11:00:11 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-27 11:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/359763002/20001
6 years, 5 months ago (2014-06-27 11:02:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 12:03:27 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 12:12:38 UTC) #6
Message was sent while issue was closed.
Change committed as 177094

Powered by Google App Engine
This is Rietveld 408576698