Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 359713005: Don't leak the global object in the Function constructor. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Don't leak the global object in the Function constructor. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-function-constructor-receiver.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-06-27 09:42:09 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-06-27 09:42:52 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-06-27 13:50:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698