Source/bindings/templates/attributes.cpp - Issue 359703002: IDL: Remove a FIXME comment for using local variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 359703002: IDL: Remove a FIXME comment for using local variables (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index e7393c1a409ff84431f950c7336801b24634aa35..e715340a77e8e8a3826a432bfe22e2026154c7dc 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -62,7 +62,6 @@ const v8::PropertyCallbackInfo<v8::Value>& info

return;

{% endif %}

{% if attribute.is_check_security_for_node %}

- {# FIXME: use a local variable to not call getter twice #}

if (!BindingSecurity::shouldAllowAccessToNode(info.GetIsolate(), {{attribute.cpp_value}}, exceptionState)) {

v8SetReturnValueNull(info);

exceptionState.throwIfNeeded();

« no previous file with comments | « no previous file | no next file » | no next file with comments »