Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 359693002: GN: Add make_core_generated->m..private_script dep (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

GN: Add make_core_generated->m..private_script dep This is needed to build the generated bindings. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
lgtm
6 years, 5 months ago (2014-06-27 23:06:31 UTC) #1
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-06-27 23:13:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/359693002/1
6 years, 5 months ago (2014-06-27 23:15:01 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 00:39:00 UTC) #4
Message was sent while issue was closed. 
Change committed as 177159

Powered by Google App Engine
This is Rietveld 408576698