Simplify the QuicDispatcher::OnCanWrite logic

net/tools/quic/quic_dispatcher.h

Index: net/tools/quic/quic_dispatcher.h
diff --git a/net/tools/quic/quic_dispatcher.h b/net/tools/quic/quic_dispatcher.h
index 9553583f7320d60acad25b1127c08c9ee11b0ac9..534cad96a286184dd5b9e1b4191d81016132f48a 100644
--- a/net/tools/quic/quic_dispatcher.h
+++ b/net/tools/quic/quic_dispatcher.h
@@ -97,7 +97,7 @@ class QuicDispatcher : public QuicServerSessionVisitor,
                                   QuicErrorCode error) OVERRIDE;
 
   // Queues the blocked writer for later resumption.
-  virtual void OnWriteBlocked(QuicBlockedWriterInterface* writer) OVERRIDE;
+  virtual void OnWriteBlocked(QuicBlockedWriterInterface* blocked) OVERRIDE;

[wtc, 2014/06/27 17:08:01]

Nit: This virtual method comes from the QuicServerSessionVisitor interface. The
parameter is named |writer| in that interface. If we think |blocked| is a better
name, we should rename the parameter throughout.

[dmziegler, 2014/06/27 17:26:42]

I called it |blocked| in order to disambiguate it from |writer_|.

[ramant (doing other things), 2014/06/27 19:18:39]

Changed it blocked_writer everywhere after talking with dmziegler.

Done.

[ramant (doing other things), 2014/06/27 19:18:39]

Acknowledged.

 
   typedef base::hash_map<QuicConnectionId, QuicSession*> SessionMap;
 
@@ -106,8 +106,6 @@ class QuicDispatcher : public QuicServerSessionVisitor,
 
   const SessionMap& session_map() const { return session_map_; }
 
-  WriteBlockedList* write_blocked_list() { return &write_blocked_list_; }
-
  protected:
   // Instantiates a new low-level packet writer. Caller takes ownership of the
   // returned object.