Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 359623004: Don't preload all tokens (Closed)

Created:
6 years, 6 months ago by eseidel
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, mkwst+watchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Don't preload all tokens Turns out we're not really ready to do this. The preloader has lots of bugs at least in the re-use-existing-preload logic. Yes, we should fix these bugs. Yes, making all tokens go through the preloader would force us to fix these bugs. But until we do, it seems better to sweep them back under the rug (and just have flakiness in the wild) rather than making preloader bugs completely unavoidable by forcing every token through it. This is a partial revert of: https://codereview.chromium.org/302063002/ BUG=356292, 388308, 389226 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/dont-load-unknown-type.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/events/drag-and-drop-autoscroll-inner-frame.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/tables/mozilla_expected_failures/bugs/bug128876-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eseidel
The only part I didn't revert was the ResourceFetcher changes (which fixed actual bugs in ...
6 years, 6 months ago (2014-06-26 18:26:34 UTC) #1
abarth-chromium
LGTM
6 years, 6 months ago (2014-06-26 18:43:15 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 6 months ago (2014-06-26 18:43:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/359623004/1
6 years, 6 months ago (2014-06-26 18:44:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-26 19:37:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 20:09:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/26379)
6 years, 6 months ago (2014-06-26 20:09:19 UTC) #7
eseidel
Odd. "gaia" error on win gpu: FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" ...
6 years, 6 months ago (2014-06-27 00:04:37 UTC) #8
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 6 months ago (2014-06-27 00:04:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/359623004/1
6 years, 6 months ago (2014-06-27 00:05:54 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 02:22:45 UTC) #11
Message was sent while issue was closed.
Change committed as 177044

Powered by Google App Engine
This is Rietveld 408576698