Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 359593002: Selection should be updated after node is moved to another document (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: WIP Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3719 matching lines...) Expand 10 before | Expand all | Expand 10 after
3730 if (!m_ranges.isEmpty()) { 3730 if (!m_ranges.isEmpty()) {
3731 AttachedRangeSet::const_iterator end = m_ranges.end(); 3731 AttachedRangeSet::const_iterator end = m_ranges.end();
3732 for (AttachedRangeSet::const_iterator it = m_ranges.begin(); it != end; ++it) 3732 for (AttachedRangeSet::const_iterator it = m_ranges.begin(); it != end; ++it)
3733 (*it)->nodeChildrenChanged(container); 3733 (*it)->nodeChildrenChanged(container);
3734 } 3734 }
3735 } 3735 }
3736 3736
3737 void Document::updateRangesAfterNodeMovedToAnotherDocument(const Node& node) 3737 void Document::updateRangesAfterNodeMovedToAnotherDocument(const Node& node)
3738 { 3738 {
3739 ASSERT(node.document() != this); 3739 ASSERT(node.document() != this);
3740 if (m_ranges.isEmpty()) 3740 if (!m_ranges.isEmpty()) {
3741 return; 3741 AttachedRangeSet ranges = m_ranges;
3742 AttachedRangeSet ranges = m_ranges; 3742 AttachedRangeSet::const_iterator end = ranges.end();
3743 AttachedRangeSet::const_iterator end = ranges.end(); 3743 for (AttachedRangeSet::const_iterator it = ranges.begin(); it != end; ++ it)
3744 for (AttachedRangeSet::const_iterator it = ranges.begin(); it != end; ++it) 3744 (*it)->updateOwnerDocumentIfNeeded();
3745 (*it)->updateOwnerDocumentIfNeeded(); 3745 }
3746
3747 if (LocalFrame* frame = this->frame()) {
3748 if (!frame->selection().isNone()) {
yosin_UTC9 2014/06/27 01:39:24 FrameSelection::firstRange() returns faked Range o
3749 RefPtrWillBeRawPtr<Range> range = frame->selection().firstRange();
3750 range->updateOwnerDocumentIfNeeded();
3751 frame->selection().setSelection(VisibleSelection(range.get()));
3752 }
3753 }
3746 } 3754 }
3747 3755
3748 void Document::nodeChildrenWillBeRemoved(ContainerNode& container) 3756 void Document::nodeChildrenWillBeRemoved(ContainerNode& container)
3749 { 3757 {
3750 NoEventDispatchAssertion assertNoEventDispatch; 3758 NoEventDispatchAssertion assertNoEventDispatch;
3751 if (!m_ranges.isEmpty()) { 3759 if (!m_ranges.isEmpty()) {
3752 AttachedRangeSet::const_iterator end = m_ranges.end(); 3760 AttachedRangeSet::const_iterator end = m_ranges.end();
3753 for (AttachedRangeSet::const_iterator it = m_ranges.begin(); it != end; ++it) 3761 for (AttachedRangeSet::const_iterator it = m_ranges.begin(); it != end; ++it)
3754 (*it)->nodeChildrenWillBeRemoved(container); 3762 (*it)->nodeChildrenWillBeRemoved(container);
3755 } 3763 }
(...skipping 2079 matching lines...) Expand 10 before | Expand all | Expand 10 after
5835 visitor->trace(m_compositorPendingAnimations); 5843 visitor->trace(m_compositorPendingAnimations);
5836 visitor->trace(m_contextDocument); 5844 visitor->trace(m_contextDocument);
5837 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this); 5845 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
5838 DocumentSupplementable::trace(visitor); 5846 DocumentSupplementable::trace(visitor);
5839 TreeScope::trace(visitor); 5847 TreeScope::trace(visitor);
5840 ContainerNode::trace(visitor); 5848 ContainerNode::trace(visitor);
5841 ExecutionContext::trace(visitor); 5849 ExecutionContext::trace(visitor);
5842 } 5850 }
5843 5851
5844 } // namespace WebCore 5852 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698