Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 359533004: Group flakiness results by blink revision (Closed)

Created:
6 years, 5 months ago by pdr.
Modified:
6 years, 5 months ago
Reviewers:
jparent, ojan, eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Group flakiness results by blink revision This patch reorganizes the flakiness dashboard to group results by blink revision so that regressions are easier to spot. With patch: http://head-and-shoulders.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg Without patch: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fbatik%2Ffilters%2FfeTile.svg This patch works by creating an array of the unique builds. In the simplest case this array will have a blink revision corresponding to each unique build, and each column in the flakiness results will correspond to one of these blink revisions. Because a bot can run a test multiple times for the same blink revision (e.g., if the chrome version changed), blinkBuildRevisions can return multiple entries with the same blink revision. htmlForTestResults has been updated to use the new unique revisions. To make the results easier to understand, we "interpolate" results for revisions that were not tested. For example, if r123 passed and r126 passed, r124 can be an interpolated result which probably passed. These interpolated results use a lighter color. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178388

Patch Set 1 #

Patch Set 2 : Revert local app.yaml change #

Total comments: 12

Patch Set 3 : Update per reviewer comments #

Patch Set 4 : Address reviewer comments #

Total comments: 10

Patch Set 5 : Fix currentTime bug, add support for chrome revisions, update question mark color #

Patch Set 6 : Moon lander #

Patch Set 7 : Use isBlinkGroup instead of isLayoutTestResults #

Patch Set 8 : min-width >   #

Patch Set 9 : Cleanup for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -17 lines) Patch
M Tools/TestResultServer/static-dashboards/flakiness_dashboard.js View 1 2 3 4 5 6 7 8 8 chunks +121 lines, -10 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js View 1 2 3 4 5 6 7 8 4 chunks +118 lines, -6 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/history.js View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
pdr.
6 years, 5 months ago (2014-06-28 21:00:58 UTC) #1
ojan
I like the direction this is going! But the UI still needs some flushing out. ...
6 years, 5 months ago (2014-06-29 03:38:49 UTC) #2
pdr.
https://codereview.chromium.org/359533004/diff/20001/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js File Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (right): https://codereview.chromium.org/359533004/diff/20001/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js#newcode555 Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:555: for (var idx = 0; idx < blinkRevisions.length; idx++) ...
6 years, 5 months ago (2014-06-29 20:51:34 UTC) #3
pdr.
On 2014/06/29 03:38:49, OOO-only-code-yellow-reviews wrote: > I like the direction this is going! But the ...
6 years, 5 months ago (2014-06-29 20:52:19 UTC) #4
ojan
pdr and I chatted about this offline. I'm fine trying this. A few things we ...
6 years, 5 months ago (2014-07-10 00:25:10 UTC) #5
pdr.
On 2014/07/10 00:25:10, ojan-only-code-yellow-reviews wrote: > pdr and I chatted about this offline. I'm fine ...
6 years, 5 months ago (2014-07-13 21:45:18 UTC) #6
ojan
lgtm I think this is a big improvement. Fix the commented issues before landing of ...
6 years, 5 months ago (2014-07-14 23:40:39 UTC) #7
pdr.
I think we're ready to land! @Ojan, want to take one last look? https://codereview.chromium.org/359533004/diff/60001/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js File ...
6 years, 5 months ago (2014-07-17 14:50:29 UTC) #8
ojan
lgtm
6 years, 5 months ago (2014-07-17 18:35:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/359533004/160001
6 years, 5 months ago (2014-07-17 18:36:07 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 18:37:25 UTC) #11
Message was sent while issue was closed.
Change committed as 178388

Powered by Google App Engine
This is Rietveld 408576698